Comments on: Creating a routing-based menu in symfony 1.2, part 3: the builder http://blog.vworld.at/2009/04/03/creating-a-routing-based-menu-in-symfony-12-part-3-the-builder/ Software development and software quality Thu, 17 Jun 2010 20:00:56 +0000 http://wordpress.org/?v=2.9.2 hourly 1 By: David http://blog.vworld.at/2009/04/03/creating-a-routing-based-menu-in-symfony-12-part-3-the-builder/comment-page-1/#comment-1823 David Sat, 04 Apr 2009 12:31:40 +0000 http://blog.vworld.at/?p=112#comment-1823 Thanks for your input, I will include this in the final version. For the same reason I inject the routing information into the sfMenuItem objects, but of course the context should also be injected. Thanks for your input, I will include this in the final version. For the same reason I inject the routing information into the sfMenuItem objects, but of course the context should also be injected.

]]> By: Hugo http://blog.vworld.at/2009/04/03/creating-a-routing-based-menu-in-symfony-12-part-3-the-builder/comment-page-1/#comment-1822 Hugo Sat, 04 Apr 2009 09:40:24 +0000 http://blog.vworld.at/?p=112#comment-1822 Hello, That's a great serie of symfony articles but there is one bad practice you show. You shouldn't have to call the context inside your class but pass it from the outside. The problem is that calling sfContext::getInstance() inside a classe evolves a string coupling with your class and avoid it to be unit tested... The solution is to create a getter and a setter to pass the context from outside the class. <pre lang="php"> public function setContext($context) { $this->context = $context; } public function getContext() { return $this->context; } // ... } </pre> You can also pass the context as a constructor argument. ++ Hello,

That’s a great serie of symfony articles but there is one bad practice you show. You shouldn’t have to call the context inside your class but pass it from the outside. The problem is that calling sfContext::getInstance() inside a classe evolves a string coupling with your class and avoid it to be unit tested… The solution is to create a getter and a setter to pass the context from outside the class.

  public function setContext($context)
  {
    $this->context = $context;
  }
 
  public function getContext()
  {
    return $this->context;
  }
 
  // ...
}

You can also pass the context as a constructor argument.

++

]]>